Replaces the zipzip gem with the rubyzip gem #6001
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # c.continue_on_exists_proc = true | ||
| # c.unicode_names = true | ||
| # c.default_compression = Zlib::BEST_COMPRESSION | ||
| # end |
There was a problem hiding this comment.
I don't think we need this, we can always add it if we do want to configure it ;)
…it rubyzip gem version in Gemfile with description
|
Thanks @jhass , made the changes, please let me know if there is anything else, thanks again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR replaces the zipzip gem with the rubyzip gem. There was a time when the selenium-webdriver gem needed the zipzip gem to interface with rubyzip < 1 but the current version of selenium-webdriver uses rubyzip ~> 1.
The only place other than from selenium-webdriver that rubyzip is used is in the user model (User.new.perform_export_photos! - https://github.com/diaspora/diaspora/blob/develop/app/models/user.rb#L328)
Also added an initializer for rubyzip configurations in case anyone wanted or needed the ability to configure it.
Hopefully this helps and let me know if there are any issues with it, thanks!