Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable self-notification possibility #6512

Closed
wants to merge 1 commit into from
Closed

Disable self-notification possibility #6512

wants to merge 1 commit into from

Conversation

cmrd-senya
Copy link
Member

fixes #6506

@cmrd-senya cmrd-senya mentioned this pull request Oct 20, 2015
Closed
@jhass
Copy link
Member

jhass commented Oct 20, 2015

Please at least add a spec for this to https://github.com/diaspora/diaspora/blob/develop/spec/models/notification_spec.rb#L65

@cmrd-senya cmrd-senya force-pushed the 6506-self-notification-regression branch from 22d0a68 to 5fc4208 Compare October 20, 2015 13:23
@cmrd-senya
Copy link
Member Author

@jhass, is that enough?

@jhass
Copy link
Member

jhass commented Oct 20, 2015

Yeah, should be good enough.

@jhass jhass added this to the 0.5.5.0 milestone Oct 20, 2015
@jhass jhass closed this in 00588e1 Oct 20, 2015
@jhass
Copy link
Member

jhass commented Oct 20, 2015

Merged as 00588e1

Thanks.

@cmrd-senya cmrd-senya deleted the 6506-self-notification-regression branch October 21, 2015 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.5.5.0
Development

Successfully merging this pull request may close these issues.

Receiving notifications for own comment on own reshare
2 participants
@cmrd-senya @jhass