White color theme #6631
White color theme #6631
Conversation
|
Thanks for that! I'm sure many are not going to want the new design, to provide them an easy way to keep the old design is really needed. Is it hard to re-add a left grey border to the stream? It looks a bit weird without it when you compare to the current 0.5 design. |
|
Also, the background of the chat is still grey, I don't know if we can control that from the diaspora* code or if it's in JSXC. |
svbergerem
force-pushed
the
white-color-theme
branch
from
1f2776c
to
559d8c8
Compare
Done and just updated the screenshot.
Chat changes won't be part of this PR. |
|
The border is still missing on the profile and tag page. Looks great otherwise, tested with both chromium and Firefox. |
svbergerem
force-pushed
the
white-color-theme
branch
from
559d8c8
to
5bd15e2
Compare
Done. |
| .left-navbar-fixed-background, | ||
| &.page-tags .left-navbar-fixed-background, | ||
| .left-navbar { | ||
| border-right: 1px solid $border-grey; |
There was a problem hiding this comment.
You should put a border-left on the content instead. With that, the border stop at the end of the left elem which is usually pretty short (look at a profile page with only an avatar for example).
There was a problem hiding this comment.
I tried that but it looked weird without changing some padding/margin of the stream / the profile header. I'm not planning to change this kind of stuff since these changes are much more likely to break stuff later when we adjust the original "theme". I'd also like to emphasis that we are talking about a "color theme" here.
|
Is this default? Ps. Some description would be nice in PR's ;) |
No, it is the second color theme in the list. We have a new default design and this color theme is for those who don't like it.
What kind of information is missing? The title says that this is a color theme and the screenshot shows how it will look like. If there is anything missing then I'll add it to the description. |
Awesome 👍
Just a general note, sorry. I think it is good practise, towards other people, to give a description, for even obvious things, like whether this is default. |
|
LGTM, thank you. We can always touch it up with further PRs. |
Supersedes #6402.