6840 : meta tags update #6998
Merged
6840 : meta tags update #6998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # licensed under the Affero General Public License version 3 or later. See | ||
| # the COPYRIGHT file. | ||
|
|
||
| class TagPresenter < BasePresenter |
There was a problem hiding this comment.
TagPresenter to me sounds like being for a single Tag, how about TagStreamPresenter?
There was a problem hiding this comment.
Sure! Would be better indeed.
|
you must have meant #6840 |
| og_profile_username: { property: 'og:profile:username' , content: name }, | ||
| og_profile_firstname:{ property: 'og:profile:first_name', content: first_name }, | ||
| og_profile_lastname: { property: 'og:profile:last_name' , content: last_name } | ||
| } |
There was a problem hiding this comment.
You can use the bio as a description here if public_details?, else not.
|
Woops, yes, that was supposed to be 6840. Sorry. |
| og_image: {property: "og:image", content: images}, | ||
| og_description: {property: "og:description", content: description}, | ||
| og_article_tag: {property: "og:article:tag", content: tags}, | ||
| og_article_author: |
There was a problem hiding this comment.
Align the elements of a hash literal if they span more than one line.
…rivacy concerns to be cleared.
| # licensed under the Affero General Public License version 3 or later. See | ||
| # the COPYRIGHT file. | ||
|
|
||
| class StreamTagPresenter < BasePresenter |
There was a problem hiding this comment.
I think I prefer TagStreamPresenter, StreamTagPresenter sounds like it's for a special kind of tag, a "stream tag", while it's a special kind of stream, a "tag stream".
|
Thank you very much! |
jhass
added a commit
that referenced
this pull request
Aug 18, 2016
SuperTux88
added a commit
to SuperTux88/diaspora
that referenced
this pull request
Aug 21, 2016
* fixed old reshares of reshares * fixed deleted root of a reshare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6840
Hope I'm following your styleguides correctly and that my tests are good enough!