Add some progress indicators to the account deletions rake task #7646
Conversation
|
Thanks! Can you please also add an indication in the changelog that it can take a while, and maybe should be run in tmux? |
|
It doesn't need to be run in tmux, when it stops or is canceled (Ctrl-C) it just continues where it's stopped after restart. The account deletion is only marked as completed when it's completed. |
| puts "OK." | ||
| else | ||
| puts "No acccount deletions to run." | ||
| puts "No account deletions to run." |
There was a problem hiding this comment.
I copy pasted that from an older rake task ... and while adding the progress indicators the spell-checker of my IDE told me that there is something wrong here ;)
|
Merged as c9423bf Thanks @denschub for the review 🍪 @Flaburgan what I wanted to say was, that you don't need tmux, but if you have an unstable connection you maybe use tmux for the upgrade anyway and then you can continue using tmux. But if something happens you can just restart it and it continues where it's stopped, so nothing bad happens :) |
@Flaburgan asked if the rake task is stuck, because it doesn't output anything until it's finished (which can take a while when there are multiple accounts or big accounts needed to be deleted). So I thought it's maybe a good idea to print some stuff.