Improve like tests #8002
Closed
Improve like tests #8002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| end | ||
|
|
||
| Then /^I should see the Bitcoin address$/ do | ||
| find("#bitcoin_address")['value'].should == "AAAAAA" |
There was a problem hiding this comment.
Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| var elem = $(el); | ||
| if ('" + text + "' == $.trim(elem.text()) ) { | ||
| elem.click(); | ||
| }});") |
There was a problem hiding this comment.
Layout/MultilineMethodCallBraceLayout: Closing method call brace must be on the line after the last argument when opening brace is on a separate line from the first argument.
jhass
approved these changes
Apr 28, 2019
Flaburgan
force-pushed
the
improve-like-tests
branch
from
3dc0547
to
f62ceeb
Compare
|
Style check fixed and I finished the improvements I wanted to do but I haven't time for it on Sunday. So this should be ready to be merged. |
|
@jhass travis is green ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reorganize a bit the cucumber steps and improve the like steps. It is a base for the coming cucumber tests I'm writing for #2999.