Refactor hovercards, fix #8315 #8316
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flaburgan
force-pushed
the
8315-default-avatar-hovercards
branch
from
7f6a364
to
bd881e7
Compare
|
Hm, I don't understand Jasmine failure, what is going on here? |
Flaburgan
force-pushed
the
8315-default-avatar-hovercards
branch
from
bd881e7
to
779fd1d
Compare
|
Okay Jasmine tests are fixed. |
SuperTux88
approved these changes
Nov 8, 2021
|
Merged as f6c8853 Thanks for the PR 🍪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now process the template with handlebars syntax instead of by JS. That fixes #8315 and should allow me to handle #6542 and #7469 after.