Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update faraday and faraday_middleware to 1.0 #116

Merged
merged 3 commits into from Jun 29, 2021

Conversation

pravi
Copy link
Contributor

@pravi pravi commented Jun 16, 2021

Closes #115

1 test is failing


  1) DiasporaFederation::HttpClient.get follows redirects not more than 4 times
     Failure/Error: expect { HttpClient.get("http://www.example.com") }.to raise_error FaradayMiddleware::RedirectLimitReached

     NameError:
       uninitialized constant FaradayMiddleware::RedirectLimitReached
     # ./spec/lib/diaspora_federation/http_client_spec.rb:36:in `block (3 levels) in <module:DiasporaFederation>'

@SuperTux88 SuperTux88 merged commit 5a021a9 into diaspora:develop Jun 29, 2021
@pravi
Copy link
Contributor Author

pravi commented Jun 29, 2021

@SuperTux88 thanks, can you make a new release so I can try updating Faraday in diaspora as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update faraday dependency to 1.0
2 participants