Compiling as C

[AJenbo]

This issue is for tracking the status of converting the project to C in order to get things more binary exact.

General issue

• storm.h isn't loaded in a way that allows the compiler to recognize the function names.
• diabloui.h isn't loaded in a way that allows the compiler to recognize the function names.
• static float *_cpp_init_value = INFINITY; this was probably put here by the compiler because of crtical sections or similar and should be safe to remove for now.
• ddraw.h isn't being referenced in a way that allows the compiler to recognize the structure memberse.
• dsound.h isn't being referenced in a way that allows the compiler to recognize the structure memberse.
• We need a C replacment for init_event, this is relatet to the _cpp_init_ structures. C init #549
  • dthread.cpp
  • dx.cpp init
  • logging.cpp
  • fault.cpp
  • msgcmd.cpp
  • nthread.cpp
• Some functions still use C++ only helpers (__ROR2__, __ROR4__, __OFSUB__)
  • control.cpp
    • DrawSpellCel Replace __ROR4__ stdlib, make _ROR2__ C frindly #540
    • CheckChrBtns
    • control_set_gold_curs
  • drlg_l3.cpp
    • DRLG_L3River Clean up __OFSUB__ usage #539
  • engine.cpp
    • CelDecDatLightTrans Replace __ROR4__ stdlib, make _ROR2__ C frindly #540
    • Cel2DecDatLightTrans Replace __ROR4__ stdlib, make _ROR2__ C frindly #540
  • items.cpp
    • GetItemSpace
  • lighting.cpp
    • DoLighting Clean up __OFSUB__ usage #539
  • monster.cpp
    • M_TryH2HHit Clean up __OFSUB__ usage #539
    • MAI_Counselor Clean up __OFSUB__ usage #539
  • objects.cpp
    • AddSarc
    • AddBarrel
    • Obj_FlameTrap
    • Obj_Trap
    • MonstCheckDoors
    • OperateL1Door
    • OperateL2Door
  • stores.cpp
    • StoreSellItem Clean up __OFSUB__ usage #539
    • S_SRepairEnter Clean up __OFSUB__ usage #539
    • S_WRechargeEnter Clean up __OFSUB__ usage #539
    • HealerBuyItem Clean up __OFSUB__ usage #539
    • CheckStoreBtn Clean up __OFSUB__ usage #539

File issues

• appfat.cpp Byte-identical version of appfat_cpp_init. #110
  • delete is being overloaded
• capture.cpp
  • Looks like we are missing io.h
• diablo.cpp
  • looks like we need winuser.h
  • line 297 char szValueName[] = "Intro";
• missiles.cpp
  • unsigned char Dirs[16][16] = {...} needs to be rewritten in a C friendly way.
• movie.cpp (Compile movie.cpp as C #529)
  • LRESULT return type appears to not allow NULL, use 0?
• mpqapi.cpp Compile mpqapi.cpp as C #554
  • mpqapi_open_archive(const char *pszArchive, ...) first parameter gives the following errors C4028, C4090, C4024
• pfile.cpp
  • char password[16] = PASSWORD_SINGLE; needs to be rewritten in a C friendly way.
• wave.cpp
  • SFileReadFile(1,2,3,4,NULL) produce an error
• render.cpp
  • asm_* the C compiler is unhappy with the inline format. Make inline statments C compatible #550
  • asm_* dst & src are passed by references, this isn't allowed in C.

[mewmew]

The list of files that do not yet compile as C, as of rev ca64011.

• delete operator

  • Source/appfat.cpp

• cinit

  • Source/dthread.cpp
  • Source/dx.cpp
  • Source/engine.cpp
  • Source/fault.cpp
  • Source/logging.cpp
  • Source/msgcmd.cpp
  • Source/nthread.cpp

[mewmew]

🎉 We are now closer to getting a matching Rich header :)