Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch next #271

Closed
wants to merge 38 commits into from
Closed

Switch next #271

wants to merge 38 commits into from

Conversation

AJenbo
Copy link
Member

@AJenbo AJenbo commented Sep 23, 2019

This is just for testing that things build before replacing #181

@AJenbo AJenbo force-pushed the switch-next branch 4 times, most recently from bfbe71b to ee833b8 Compare September 24, 2019 02:21
@AJenbo
Copy link
Member Author

AJenbo commented Sep 24, 2019

@glebm would you be willing to help out with sorting out the SDL1 implementation for this branch? It looks to be mostly just SDL_GameControler related things at this point. For now they can just be #ifndef SDL1 so that it passes the build test, then we can work on some kind of alternate implementation in a PR that focuses on the game controller code alone.

@glebm
Copy link
Collaborator

glebm commented Sep 24, 2019

@AJenbo Sure, on it. Is there a developer discord for devilutionX btw?

@AJenbo
Copy link
Member Author

AJenbo commented Sep 24, 2019

@glebm the discord link is in top of the ReadMe, I'm surprised how many miss it :)

@AJenbo AJenbo force-pushed the switch-next branch 2 times, most recently from d62434f to b89050d Compare September 26, 2019 06:05
@AJenbo
Copy link
Member Author

AJenbo commented Sep 26, 2019

Looks like we have taken care of most of the issues with the Switch platform support:

The only other things are missing are:

  1. Generate a config.h with name and version (see config.h.in) when running make
  2. Display the error messages from appfat.cpp correctly to the user
  3. Allow the user to enter a name for there hero
  4. Move the remaining hardcoded resolution (either use SDL for this or move it to where we call SDL for other platforms.

However, this branch still needs testing.

The rest looks to be mostly just the controller code, and it should really be done as a separate PR.

@rsn8887
Copy link
Contributor

rsn8887 commented Sep 26, 2019

Concerning 3. already implemented ages ago (opens virtual keyboard for name entry)

Concerning 2. Maybe just write the errors to a log file as .txt? There's no system dialog box that is accessible to homebrew. So to display one, we would have to draw it ourselves, handle input for it etc. sounds like a lot of work for nothing.

@AJenbo
Copy link
Member Author

AJenbo commented Sep 26, 2019

Actually I might have a solution for 2, my Mac is apparently also affected so I can test it there. What happens if we call the dialog code at all?

@rsn8887
Copy link
Contributor

rsn8887 commented Sep 26, 2019

If you are thinking SDL would provide a dialog box, no. Not on Switch.

@AJenbo
Copy link
Member Author

AJenbo commented Sep 26, 2019

Yeah I understand, we where already using SDL2. It's the same on my 2002 Mac. Do you get an error in the terminal (can't remember if you have access to it) when trying to create the dialog? I get something like "no messaging system available"

rsn8887 and others added 26 commits September 30, 2019 05:52
Including artifacts for any one that wants to test nightly
@AJenbo AJenbo closed this Sep 30, 2019
@AJenbo AJenbo deleted the switch-next branch September 30, 2019 03:57
qndel pushed a commit to qndel/devilutionX that referenced this pull request Oct 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants