Nintendo Switch

[AJenbo]

This is an effort to upstream the Switch port created by @lantus (MVG) in a manner that maintains other ports and full credit via git commits. To do so some commits have been edited, mainly when the change is both temporary and destructive or could cause conflicts.

This will hopefully help to resolve lantus/devilution-nx#7

MVG's video about the project:
https://www.youtube.com/watch?v=5tADL_fmsHQ&t=34s

This PR is currently in draft mode while we work out some outstanding issues regarding the merge:

• Unify code where there doesn't need to be a difference between Switch and other ports
• Make a separate #ifdef for controller code and switch code so it can be enabled independently
• Create a readme with Switch relevant info in the switch folder
• Cherry pick all commits from https://github.com/lantus/devilution-nx without breaking other platforms
• Reduce changes in the Source/ folder to a minimum
• See if manipulating MouseX/MouseY directly is needed if SetCursorPos is re-enabled
• Remove libsodium dependency for Switch
• Expose DSBSTATUS_PLAYING in a way that is picked up by the Switch build process
• Fix macOS builds
• Merge with the latest code from master
• Fix escaping videoes via keyboard input
• Fix SDL1 builds

New features compared to devilution-nx:

• All builds are now automatically compiled for the switch via CircleCI
• Map all keyboard keys
• Fix save game compatibility
• Add missing shadow in the credits
• Fix zooming in the minimap for some keyboards
• Fix typos
• Fix TCP code
• Correct directional sounds
• Fix multiplayer bug
• All code now matches the original Diablo (fixing a few in game bugs)
• Tons of code clean up and better code documentation
• Fix clang-format configuration
• Correct file encoding
• Fix crash in town with some compilers
• Correct crash when exiting menu
• Error messages implemented in GUI
• Much lower CPU usage
• FPS no longer locked to 20
• Many bug fixes in the controller implementation
• More responsive controller
• highlight both primary and secondary target

[mewmew]

Now we just have to get a Switch console for our CI cluster :p

[AJenbo]

I have taken care of most of the platform code. If anyone could test that it still loads correctly on there switch that would be a huge help:
https://1663-143324737-gh.circle-artifacts.com/0/diablo-nx.nro

[mewmew]

@AJenbo, do you need to do something specific to make it possible to run custom ROMs on the Switch?

[ghost]

to make it possible to run custom ROMs on the Switch?

As someone who originated from the console scene, I can say very much you aren't going to be running any custom code on a modern console without some sort of userland exploit. The Switch came with a design flaw that allowed them to be hacked to run unsigned code but Nintendo revised the motherboard so newer models cannot.

Modern consoles have sigchecks on code and certain keys are used to sign it based on desired user level access, with kernel keys being reserved for firmware devs and userland for game devs.

[AJenbo]

This port is now in fairly good shape, the only parts that are missing relates to cleaning up the controller code.

It would also be great to get it compiling using CMake rather than a custom make script @lantus is this something you have experience with?

[AJenbo]

Controller code has now been cleaned up and the build process moved to CMake, both thanks to @glebm.
This also brings several improvements to the controleller code in terms of responsiveness and issue and bugs being fixed (no more talking to ghosts in the dungion).

All that remains is basically to see if SetCursorPos can be reenabled and a handful of other minor cleanups outlined in #443

[ghost]

All that remains is basically to see if SetCursorPos can be reenabled

Honestly I don't mind that one being disabled. Having the cursor move around when i show the inventory or spell list is quite annoying.

[AJenbo]

@galaxyhaxz well it is also needed for keeping the mouse in sync with the emulated mouses (touch and game controller), so would just be nice to have it work the same on all devices. @rsn8887 isn't it possible to attach mouse an keyboard to the Switch and play the game with that?

[rsn8887]

Yes that is possible and works, or at least used to work always, so... hmm... I guess all the SDL mouse stuff should work on Switch after all. The touch code already works by pushing SDL events into the event queue. I think only the analog joystick mouse was still using an emulated mouse. However the analog joystick mouse could/should probably also be implemented in such a way that it pushes SDL mousemotion events every frame, instead of the hack it currently is?!

[glebm]

@rsn8887 SetCursorPos calls SDL_WarpMouseInWindow which generates a mouse motion event:

devilutionX/SourceX/controls/plrctrls.cpp

Line 582 in 2bb9aa4

SetCursorPos(x, y);