Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore default Windows audio driver (WASAPI) #4023

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

StephenCWills
Copy link
Member

@StephenCWills StephenCWills commented Feb 3, 2022

With the SDL 2.0.18 change to use the built-in WASAPI audio resampler (libsdl-org/SDL@ac32c52) and the recent vcpkg update to move from SDL 2.0.16 to SDL 2.0.20 (microsoft/vcpkg@9eb76eda), this seems like a pretty good time to reintroduce WASAPI.

While testing various audio settings, we found that resampling quality can have a pretty significant impact on game performance. Therefore, I'd also like to propose reducing the default resampling quality from 5 to 3 based on guidelines found in the Speex resampler documentation.

https://speex.org/docs/manual/speex-manual/node7.html#SECTION00760000000000000000
Usually, a quality of 3 is acceptable for most desktop uses and quality 10 is mostly recommended for pro audio work. Quality 0 usually has a decent sound (certainly better than using linear interpolation resampling), but artifacts may be heard.

See also:
#1434, #1435

@AJenbo AJenbo merged commit 8d5b709 into diasurgical:master Feb 3, 2022
@StephenCWills StephenCWills deleted the wasapi branch February 3, 2022 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants