Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore default Windows audio driver (WASAPI) #4023

Merged
merged 1 commit into from
Feb 3, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Packaging/windows/mingw-prep.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bash

SDLDEV_VERS=2.0.18
SDLDEV_VERS=2.0.20
SODIUM_VERS=1.0.18

# exit when any command fails
Expand Down
2 changes: 1 addition & 1 deletion Source/options.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ namespace devilution {
#define DEFAULT_AUDIO_BUFFER_SIZE 2048
#endif
#ifndef DEFAULT_AUDIO_RESAMPLING_QUALITY
#define DEFAULT_AUDIO_RESAMPLING_QUALITY 5
#define DEFAULT_AUDIO_RESAMPLING_QUALITY 3
#endif

namespace {
Expand Down
6 changes: 0 additions & 6 deletions Source/utils/display.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -192,12 +192,6 @@ bool SpawnWindow(const char *lpWindowName)
SDL_SetHint(SDL_HINT_ACCELEROMETER_AS_JOYSTICK, "0");
#endif

#if defined(_WIN32) && !defined(USE_SDL1) && !defined(__UWP__)
// The default WASAPI backend causes distortions
// https://github.com/diasurgical/devilutionX/issues/1434
SDL_setenv("SDL_AUDIODRIVER", "winmm", /*overwrite=*/false);
#endif

int initFlags = SDL_INIT_VIDEO | SDL_INIT_JOYSTICK;
#ifndef NOSOUND
initFlags |= SDL_INIT_AUDIO;
Expand Down