Switch new #443
Closed
Switch new #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AJenbo
commented
Nov 11, 2019
AJenbo
commented
Nov 11, 2019
AJenbo
force-pushed
the
switch-new
branch
2 times, most recently
from
d345189
to
eb24df6
Compare
AJenbo
commented
Nov 11, 2019
AJenbo
force-pushed
the
switch-new
branch
2 times, most recently
from
47ff367
to
8167ee3
Compare
AJenbo
commented
Nov 11, 2019
AJenbo
force-pushed
the
switch-new
branch
2 times, most recently
from
9a37b0c
to
235b8e2
Compare
glebm
requested changes
Nov 11, 2019
glebm
reviewed
Nov 11, 2019
glebm
reviewed
Nov 11, 2019
glebm
reviewed
Nov 11, 2019
glebm
reviewed
Nov 11, 2019
glebm
reviewed
Nov 11, 2019
glebm
reviewed
Nov 11, 2019
glebm
reviewed
Nov 11, 2019
glebm
reviewed
Nov 11, 2019
glebm
reviewed
Nov 11, 2019
glebm
reviewed
Nov 11, 2019
glebm
reviewed
Nov 11, 2019
glebm
reviewed
Nov 11, 2019
glebm
reviewed
Nov 11, 2019
glebm
reviewed
Nov 11, 2019
AJenbo
force-pushed
the
switch-new
branch
2 times, most recently
from
9f007a2
to
0775e93
Compare
AJenbo
force-pushed
the
switch-new
branch
6 times, most recently
from
7c51045
to
16c7a0a
Compare
AJenbo
commented
Nov 12, 2019
AJenbo
force-pushed
the
switch-new
branch
4 times, most recently
from
6fb2d64
to
526b5a0
Compare
glebm
reviewed
Nov 12, 2019
| @@ -4,7 +4,7 @@ | |||
| #include "controls/controller_motion.h" | |||
| #include "stubs.h" | |||
|
|
|||
| #ifdef SWITCH | |||
| #ifdef __SWITCH__ | |||
There was a problem hiding this comment.
We may want to move these to CMakeLists.txt
There was a problem hiding this comment.
@glebm would you be willing to make this change?
There was a problem hiding this comment.
glebm
reviewed
Nov 12, 2019
AJenbo
force-pushed
the
switch-new
branch
5 times, most recently
from
fc5140e
to
8068dfc
Compare
* Switch port: Code changes for latest devkitpro * switch/build.sh: Fewer devkitpro packages
Including artifacts for any one that wants to test nightly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I never got the time to clean up the history of #329. Since last I worked on it there have been some major changes affecting the Switch implementation, namely that controller support has now been mainlined thanks to @glebm. This has the consequence that a large number of changes from in previous PRs can now be dropped (about 1200 lines and 30 commits from the look of it) making for a much more digestible PR.
Currently, this PR is a bit rough of a rough carving but it appears to work for PC so hopfully the Switch functionality is still in a workable state. Testers are very welcome.
Note: as a consequence of the mainline controller code not being Switch centric the controller mapping will be a bit different. For now, I think we should keep this as is as more improvements are planned for the controller code (#418) and it's better to look at it once the dust settles.