Fix a bug in the simple test #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The number of elements in the sizes array is 10 not 11.
mrzv
reviewed
Dec 7, 2016
| @@ -94,11 +94,13 @@ TEST_CASE_METHOD(SimpleFixture, "Send/Recv Test", "[simple]") | |||
|
|
|||
| // atleast one message needs to be >2GB to test for the case of multi-piece | |||
| // messages | |||
| std::size_t sizes[11] = { 288, 128, 64, 32, 64, 32, 32, 64, 32, 32 }; | |||
| static const std::size_t sizes[] = { 288, 128, 64, 32, 64, 32, 32, 64, 32, 32 }; | |||
There was a problem hiding this comment.
Why not make it std::array<size_t> or even std::vector<size_t>? Then sizes.size() would work below.
There was a problem hiding this comment.
You need to explicitly specify the size in std::array, which will have to be changed whenever the list is changed. This way you can add or remove entries from the list and the size is computed by the compiler. This just seemed more convenient to me.
There was a problem hiding this comment.
Ah, good point about array, although the point about vector stands. But it's a very minor point. Let's not worry about it. I'll merge in the change now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The number of elements in the sizes array is 10 not 11.