Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix liboxli SONAME and ABI version #1240

Merged
merged 4 commits into from Aug 11, 2015
Merged

Fix liboxli SONAME and ABI version #1240

merged 4 commits into from Aug 11, 2015

Conversation

kdm9
Copy link
Contributor

@kdm9 kdm9 commented Aug 11, 2015

This just upstreams a fix from the Debian package, which ensure that the library version and SONAME match between a cd lib && make install and aptitude install liboxli-dev.

Cheers,
K

(also, ready for review @mr-c )

@mr-c
Copy link
Contributor

mr-c commented Aug 11, 2015

  • Is it mergeable?
  • Did it pass the tests?
  • If it introduces new functionality in scripts/ is it tested?
    Check for code coverage with make clean diff-cover
  • Is it well formatted? Look at make pep8, make diff_pylint_report,
    make cppcheck, and make doc output. Use make format and manual
    fixing as needed.
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Is it documented in the ChangeLog?
    http://en.wikipedia.org/wiki/Changelog#Format
  • Was a spellchecker run on the source code and documentation after
    changes were made?
  • Is the Copyright year up to date?

@mr-c
Copy link
Contributor

mr-c commented Aug 11, 2015

LGTM, thanks!

@mr-c
Copy link
Contributor

mr-c commented Aug 11, 2015

Jenkins, retest this please

mr-c added a commit that referenced this pull request Aug 11, 2015
Fix liboxli SONAME and ABI version
@mr-c mr-c merged commit 4d10de0 into master Aug 11, 2015
@mr-c mr-c deleted the fix/liboxli-soname branch August 11, 2015 19:11
@kdm9 kdm9 mentioned this pull request Aug 27, 2015
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants