Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] deprecate 'dump' command #1147

Merged
merged 2 commits into from Aug 8, 2020
Merged

[MRG] deprecate 'dump' command #1147

merged 2 commits into from Aug 8, 2020

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Aug 5, 2020

Fixes #830

Note: this is a PR into the stable branch, because we are deprecating something in 3.x and then removing in 4.0.

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov
Copy link

codecov bot commented Aug 5, 2020

Codecov Report

❗ No coverage uploaded for pull request base (stable@2093b99). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             stable    #1147   +/-   ##
=========================================
  Coverage          ?   92.43%           
=========================================
  Files             ?       73           
  Lines             ?     5695           
  Branches          ?        0           
=========================================
  Hits              ?     5264           
  Misses            ?      431           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2093b99...bace7a0. Read the comment docs.

@ctb ctb changed the title [WIP] deprecate 'dump' command [MRG] deprecate 'dump' command Aug 8, 2020
@ctb
Copy link
Contributor Author

ctb commented Aug 8, 2020

ready to review & merge!

@ctb ctb requested review from luizirber and standage August 8, 2020 15:46
@luizirber luizirber merged commit 5092774 into stable Aug 8, 2020
@luizirber luizirber deleted the deprecate_dump branch August 8, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants