[MRG] Add append option to sbt_index #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luizirber
commented
Jan 20, 2017
sourmash_lib/sbt.py
Outdated
| @@ -167,13 +167,16 @@ def parent(self, pos): | |||
| if pos == 0: | |||
| return None | |||
| p = int(math.floor((pos - 1) / self.d)) | |||
| self.nodes[p] = self.nodes[p].do_load() | |||
There was a problem hiding this comment.
If we merge #85, these .do_load calls are not needed.
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
==========================================
+ Coverage 85.64% 85.67% +0.02%
==========================================
Files 13 13
Lines 1951 1954 +3
Branches 52 52
==========================================
+ Hits 1671 1674 +3
Misses 270 270
Partials 10 10
Continue to review full report at Codecov.
|
luizirber
force-pushed
the
feature/sbt_append
branch
3 times, most recently
from
a294c26
to
255ff6a
Compare
luizirber
force-pushed
the
feature/sbt_append
branch
from
255ff6a
to
36ba7b3
Compare
luizirber
changed the title
luizirber
force-pushed
the
feature/sbt_append
branch
from
36ba7b3
to
2007c4b
Compare
|
Updated & then merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make testDid it pass the tests?make coverageIs the new code covered?without a major version increment. Changing file formats also requires a
major version number increment.
changes were made?