Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Improve our loading and saving and editing API for signatures & minhashes #155

Merged
merged 26 commits into from Apr 19, 2017

Conversation

ctb
Copy link
Contributor

@ctb ctb commented Apr 8, 2017

Changes:

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov-io
Copy link

codecov-io commented Apr 8, 2017

Codecov Report

Merging #155 into master will increase coverage by 0.11%.
The diff coverage is 89.04%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
+ Coverage   85.31%   85.42%   +0.11%     
==========================================
  Files          13       13              
  Lines        1879     1894      +15     
  Branches       52       52              
==========================================
+ Hits         1603     1618      +15     
  Misses        265      265              
  Partials       11       11
Impacted Files Coverage Δ
sourmash_lib/sourmash_args.py 93.24% <100%> (ø) ⬆️
sourmash_lib/sbtmh.py 94.73% <100%> (ø) ⬆️
sourmash_lib/signature_json.py 95.36% <75%> (+0.06%) ⬆️
sourmash_lib/commands.py 89.44% <83.33%> (ø) ⬆️
sourmash_lib/signature.py 89.11% <91.17%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1033479...266c622. Read the comment docs.

@ctb ctb changed the title Improve our loading and saving and editing API for signatures & minhashes [WIP] Improve our loading and saving and editing API for signatures & minhashes Apr 11, 2017
@ctb ctb changed the title [WIP] Improve our loading and saving and editing API for signatures & minhashes [MRG] Improve our loading and saving and editing API for signatures & minhashes Apr 18, 2017
Copy link
Member

@luizirber luizirber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ctb ctb merged commit 6609b3a into master Apr 19, 2017
@ctb ctb deleted the feature/better_sigfoo branch April 19, 2017 00:29
@luizirber luizirber added this to Done in sourmash 2.0 May 19, 2017
@luizirber luizirber removed this from Done in sourmash 2.0 May 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants