Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Citation #478

Closed
wants to merge 2 commits into from
Closed

[WIP] Citation #478

wants to merge 2 commits into from

Conversation

luizirber
Copy link
Member

@luizirber luizirber commented May 26, 2018

Fixes #259 #255

Uses duecredit to implement citation. This is pretty nice because it will collect appropriate citations for other software too. As an example, running sourmash compute results in

$ DUECREDIT_ENABLE=yes sourmash compute ...

DueCredit Report:
- Compute MinHash signatures for nucleotide (DNA/RNA) and protein sequences / sourmash/ (v 2.0.0a6) [1]

1 packages cited
0 modules cited
0 functions cited

References
----------

[1] Brown, C.T. & Irber, L., 2016. sourmash: a library for MinHash sketching of DNA. The Journal of Open Source Software, 1(5), p.27.

but running sourmash compare gives us the numpy citation too:

$ DUECREDIT_ENABLE=yes sourmash compare ...

DueCredit Report:
- Scientific tools library / numpy (v 1.14.3) [1]
- Compute MinHash signatures for nucleotide (DNA/RNA) and protein sequences / sourmash/ (v 2.0.0a6) [2]

2 packages cited
0 modules cited
0 functions cited

References
----------

[1] Van Der Walt, S., Colbert, S.C. & Varoquaux, G., 2011. The NumPy array: a structure for efficient numerical computation. Computing in Science & Engineering, 13(2), pp.22–30.
[2] Brown, C.T. & Irber, L., 2016. sourmash: a library for MinHash sketching of DNA. The Journal of Open Source Software, 1(5), p.27.

TODO:

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov-io
Copy link

codecov-io commented May 26, 2018

Codecov Report

Merging #478 into master will decrease coverage by 0.21%.
The diff coverage is 51.85%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #478      +/-   ##
=========================================
- Coverage   90.51%   90.3%   -0.22%     
=========================================
  Files          33      34       +1     
  Lines        4892    4919      +27     
  Branches       36      36              
=========================================
+ Hits         4428    4442      +14     
- Misses        463     476      +13     
  Partials        1       1
Impacted Files Coverage Δ
sourmash/__init__.py 100% <100%> (ø) ⬆️
sourmash/due.py 45.83% <45.83%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26cafa1...b648311. Read the comment docs.

@luizirber
Copy link
Member Author

Outputting only to stderr by default will not happen, but there is an env var to control it. In our case, we would run

$ DUECREDIT_ENABLE=yes DUECREDIT_OUTPUTS=pickle sourmash compare ...

and that won't generate any output, or

$ DUECREDIT_ENABLE=yes DUECREDIT_OUTPUTS=stderr,pickle sourmash compare ...

to generate the report to stderr.

Discussion: duecredit/duecredit#135 (comment) and duecredit/duecredit#135 (comment)

@ctb ctb added this to TODO in sourmash 2.0 Dec 24, 2018
@ctb ctb mentioned this pull request Jan 10, 2019
5 tasks
@luizirber luizirber moved this from TODO to Tentative in sourmash 2.0 Jan 11, 2019
@luizirber
Copy link
Member Author

I still think duecredit is a cool idea, but this has been open for 5 years, so I'm closing it =]

@luizirber luizirber closed this Feb 13, 2023
@luizirber luizirber deleted the feature/citation branch February 13, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
sourmash 2.0
Tentative
Development

Successfully merging this pull request may close these issues.

None yet

3 participants