Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] make sourmash compatible with khmer 3 #508

Merged
merged 1 commit into from Jun 27, 2018
Merged

[MRG] make sourmash compatible with khmer 3 #508

merged 1 commit into from Jun 27, 2018

Conversation

luizirber
Copy link
Member

@luizirber luizirber commented Jun 27, 2018

Fixes load_nodegraph being removed from khmer 3.

(Travis is testing only on khmer 2.1.1, should we put a matrix config to check on both khmer 2 and 3? My vote is no.)

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov-io
Copy link

Codecov Report

Merging #508 into master will increase coverage by 0.14%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #508      +/-   ##
==========================================
+ Coverage    90.6%   90.75%   +0.14%     
==========================================
  Files          33       33              
  Lines        5002     5007       +5     
  Branches       36       36              
==========================================
+ Hits         4532     4544      +12     
+ Misses        470      463       -7
Impacted Files Coverage Δ
sourmash/sbt.py 85.6% <50%> (-0.29%) ⬇️
sourmash/sbt_storage.py 95.5% <0%> (-1.09%) ⬇️
sourmash/lca/lca_utils.py 94.47% <0%> (+1%) ⬆️
sourmash/signature_json.py 95.51% <0%> (+1.92%) ⬆️
tests/test_signature_json.py 100% <0%> (+7.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb75f96...6226e76. Read the comment docs.

@luizirber
Copy link
Member Author

Ready for review and merge @ctb

@luizirber luizirber requested a review from ctb June 27, 2018 21:35
@ctb ctb merged commit ab67c0b into master Jun 27, 2018
@ctb ctb deleted the fix/khmer_3 branch June 27, 2018 21:50
luizirber added a commit that referenced this pull request Jul 23, 2018
- avoid calling node.data (#516)
  This makes `sourmash gather` ~40% faster...
- make sourmash compatible with khmer 3 (#508)
  Even tho khmer 3 it's not released, there is an alpha version on bioconda
- manylinux1 wheels and travis build improvements (#507)
- PyPI fixes (#504)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants