Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tarpaulin instead of grcov #862

Merged
merged 4 commits into from Jan 25, 2020
Merged

Use tarpaulin instead of grcov #862

merged 4 commits into from Jan 25, 2020

Conversation

luizirber
Copy link
Member

@luizirber luizirber commented Jan 25, 2020

Rust coverage reports are very finicky, trying out https://github.com/actions-rs/tarpaulin/ instead

Checklist

  • Is it mergeable?
  • make test Did it pass the tests?
  • make coverage Is the new code covered?
  • Did it change the command-line interface? Only additions are allowed
    without a major version increment. Changing file formats also requires a
    major version number increment.
  • Was a spellchecker run on the source code and documentation after
    changes were made?

@codecov
Copy link

codecov bot commented Jan 25, 2020

Codecov Report

Merging #862 into master will decrease coverage by 0.6%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #862      +/-   ##
==========================================
- Coverage   78.89%   78.29%   -0.61%     
==========================================
  Files          82       94      +12     
  Lines        6993     7288     +295     
  Branches      479        0     -479     
==========================================
+ Hits         5517     5706     +189     
- Misses       1174     1582     +408     
+ Partials      302        0     -302
Flag Coverage Δ
#pytests ?
#rusttests 50.66% <100%> (+3.36%) ⬆️
Impacted Files Coverage Δ
src/core/tests/signature.rs 100% <100%> (ø)
src/core/src/index/linear.rs 7.57% <0%> (-84.1%) ⬇️
sourmash/signature.py 87.19% <0%> (-0.49%) ⬇️
sourmash/sbt_storage.py 85.39% <0%> (-0.33%) ⬇️
sourmash/command_compute.py 96.96% <0%> (-0.24%) ⬇️
sourmash/sbtmh.py 84.28% <0%> (-0.23%) ⬇️
sourmash/_minhash.py 97.08% <0%> (-0.13%) ⬇️
sourmash/sbt.py 86.81% <0%> (-0.08%) ⬇️
sourmash/index.py 98.38% <0%> (-0.08%) ⬇️
sourmash/lca/lca_utils.py 96.6% <0%> (-0.06%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a601b4a...09e6437. Read the comment docs.

@luizirber luizirber changed the title [WIP] use tarpaulin instead of grcov use tarpaulin instead of grcov Jan 25, 2020
@luizirber luizirber changed the title use tarpaulin instead of grcov Use tarpaulin instead of grcov Jan 25, 2020
@luizirber luizirber requested a review from ctb January 25, 2020 06:51
@luizirber
Copy link
Member Author

Ready for review and merge @ctb

@luizirber luizirber merged commit 5948234 into master Jan 25, 2020
@luizirber luizirber deleted the rust_coverage branch January 25, 2020 17:07
@luizirber luizirber added this to the 3.2 milestone Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants