Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More refactoring of MinHash comparison code #882

Merged
merged 13 commits into from Feb 5, 2020
Merged

More refactoring of MinHash comparison code #882

merged 13 commits into from Feb 5, 2020

Commits on Feb 1, 2020

  1. refactor downsampling if/else out into downsample_max_hash function

    @ctb
    ctb committed Feb 1, 2020
    Configuration menu
    Copy the full SHA
    048b7f1 View commit details
    Browse the repository at this point in the history

  2. be more explicit about comparison types

    @ctb
    ctb committed Feb 1, 2020
    Configuration menu
    Copy the full SHA
    77609f9 View commit details
    Browse the repository at this point in the history

  3. rationalize & simplify rust side

    @ctb
    ctb committed Feb 1, 2020
    Configuration menu
    Copy the full SHA
    cf7d212 View commit details
    Browse the repository at this point in the history

  4. switch to directly calling similarity fn from Python

    @ctb
    ctb committed Feb 1, 2020
    Configuration menu
    Copy the full SHA
    703bee8 View commit details
    Browse the repository at this point in the history

  5. fix spacing

    @ctb
    ctb committed Feb 1, 2020
    Configuration menu
    Copy the full SHA
    daf6373 View commit details
    Browse the repository at this point in the history

  6. fix rust fmt

    @ctb
    ctb committed Feb 1, 2020
    Configuration menu
    Copy the full SHA
    c0ec66f View commit details
    Browse the repository at this point in the history

  7. collapse else/if block

    @ctb
    ctb committed Feb 1, 2020
    Configuration menu
    Copy the full SHA
    5d09623 View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2020

  1. Merge branch 'master' into refactor/sbtmh_2

    @ctb
    ctb committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    b862a75 View commit details
    Browse the repository at this point in the history

  2. shorter block, better names

    @ctb
    ctb committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    fa4e286 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'refactor/sbtmh_2' of github.com:dib-lab/sourmash into r… 

    …efactor/sbtmh_2
    @ctb
    ctb committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    9f6ffa2 View commit details
    Browse the repository at this point in the history

  4. remove 'compare' function from rust implementation of MinHash

    @ctb
    ctb committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    ed6f43a View commit details
    Browse the repository at this point in the history

  5. fix wasm-pack and remove compare test

    @luizirber
    luizirber committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    d551a78 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into refactor/sbtmh_2

    @luizirber
    luizirber committed Feb 5, 2020
    Configuration menu
    Copy the full SHA
    f4365aa View commit details
    Browse the repository at this point in the history