Refactoring of advanceable #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Now advance has two template parameters, Input and Output - Implement Sink and Source classes
GiulioRomualdi
force-pushed
the
refactoring/advanceable
branch
from
0feb9a4
to
691c74b
Compare
traversaro
approved these changes
Apr 1, 2021
prashanthr05
approved these changes
Apr 1, 2021
|
macOS CI is not starting, but I don't know why |
GitHub Actions had some hiccups recently: https://www.githubstatus.com/incidents/fjrtcnfz2cpd . As one macOS build passed, I think we are good to go: https://github.com/dic-iit/bipedal-locomotion-framework/runs/2246429001 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the advanceable class, in details:
This PR closes #264 and closes #196