Fix dump #423
Merged
Fix dump #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Recent commits fixed files being deleted but video thumbnails remaining. Also after removing target's files from the output, it errors because it ain't existin'. So uh, fixed that too. |
TacticalTechJay
changed the title
|
Renamed due to more fixes being committed |
diced
approved these changes
Jun 19, 2023
SinonCute
pushed a commit
to SinonCute/zipline
that referenced
this pull request
Jun 30, 2023
* fix: copying and opening another user's upload url * fix: delete thumbnails too * fix: return target after removing files from output * fix: add width to fix diced#419 (can't test) * Minor script tune-ups. * Remove the catcher for when upload has been offloaded to chunk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #420 (nice) because no url was provided by the api for the file. It also now provides the thumbnail for videos :D
Snuck in a package upgrade, doesn't seem to have broke anything