Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial DPI v16 support #158

Merged
merged 3 commits into from
Mar 6, 2023

Conversation

LexiconCode
Copy link
Member

@LexiconCode LexiconCode commented Mar 2, 2023

The adds initial support for DPI v16. This simply adds the required path for inno-code.iss

Todo:

  • Edit documentation to reflect DPI v16 support

Other thoughts
However I think how we handle version numbers within inno-code.iss could improved.

  • Better handling of logic when DNS 13 Compiled C++ code is not compatible with DPI 14/15/16
    • DragonVersion := '15'; actually handles DragonVersion 14/15/16 this should be reflected better within the code without relying on absolute version numbers.

@dougransom
Copy link
Member

looked at code, checked with author about dragonversion=15 — that is as intended.

@dougransom dougransom closed this Mar 2, 2023
@LexiconCode
Copy link
Member Author

LexiconCode commented Mar 2, 2023

looked at code, checked with author about dragonversion=15 — that is as intended.

Yes it is and that is confusing. Why is a confusing?

The installer makes decisions about which compiled .pyd is utilized. This is determined by version numbers.
this is unfortunate because _natlink_core15.pyd actually supports DPI v14/v15/v16 not just DPI v15. _natlink_core13.pyd support only DNS v13 and possibly DNS v12.

The variable dragonversion should actually represent the installed dragon version and there should be logic elsewhere to handle if it's equal or greater than or less than version DPI 14

@dougransom dougransom reopened this Mar 2, 2023
@LexiconCode LexiconCode added the WIP Work in progress (Do not Merge) label Mar 2, 2023
@LexiconCode
Copy link
Member Author

LexiconCode commented Mar 2, 2023

looked at code, checked with author about dragonversion=15 — that is as intended.

@dougransom

The BestGuessDragonIniDir updates the global variable dragonversion

function BestGuessDragonIniDir(): String;

global variable dragonversion is returned in the following function GetDragonVersion

function GetDragonVersion(Param: String): String;

GetDragonVersion is used when registering .pyd which must be v13 or v15 as those are the only two filenames that exist. See _natlink_core{code:GetDragonVersion}.pyd below

Filename: "regsvr32"; Parameters: "-s \""{#CoreDir}\_natlink_core{code:GetDragonVersion}.pyd\""" ; StatusMsg: "regsvr32 _natlink_core{code:GetDragonVersion}.pyd"

@LexiconCode LexiconCode merged commit e43233d into dictation-toolbox:master Mar 6, 2023
@LexiconCode LexiconCode deleted the DPI_16 branch March 6, 2023 18:39
@LexiconCode LexiconCode added installer and removed WIP Work in progress (Do not Merge) labels Jul 16, 2023
@LexiconCode LexiconCode self-assigned this Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants