-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mkdirTemp to System module #536
Merged
Jason2605
merged 12 commits into
dictu-lang:develop
from
briandowns:add_more_functions_to_system
Oct 6, 2022
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
e47cd8d
fix merge conflicts
briandowns d5edce6
refactor to use result
briandowns 249f1b8
fix merge conflict
briandowns 8f302cc
refactor test
briandowns ea6f0df
update test
briandowns 0eb111f
update test
briandowns a572305
fix memory
briandowns 3180464
fix memory
briandowns d54174b
fix memory
briandowns 884ff34
fix memory
briandowns c8d0d6f
start of fixes pr comments
briandowns baf5175
Handle freeing memory if returning result type
Jason2605 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
import Env; | ||
import System; | ||
|
||
const tmpDir = Env.get("TMPDIR") + "XXXXXX"; | ||
|
||
var res = System.mkdirTemp(tmpDir); | ||
|
||
print(res); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,3 +18,4 @@ import "constants.du"; | |
import "chmod.du"; | ||
import "chown.du"; | ||
import "uname.du"; | ||
import "mkdirTemp.du"; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
/** | ||
* mkdirTemp.du | ||
* | ||
* Testing the System.mkdirTemp function | ||
* | ||
* mkdirTemp makes a temporary directory. | ||
*/ | ||
from UnitTest import UnitTest; | ||
|
||
import Path; | ||
import System; | ||
|
||
class TestSystemMkdirTest < UnitTest { | ||
testSystemMkdir(tempDirName) { | ||
if (System.platform != "windows") { | ||
if (Path.exists(tempDirName)) { | ||
this.assertSuccess(System.rmdir(tempDirName)); | ||
} | ||
|
||
System.mkdirTemp(tempDirName).match( | ||
def (result) => { | ||
this.assertEquals(result[0:-6], tempDirName[0:-6]); | ||
this.assertSuccess(System.rmdir(result)); | ||
}, | ||
def (error) => { | ||
this.assertEquals(error, "Invalid argument"); | ||
} | ||
); | ||
} | ||
} | ||
|
||
testSystemMkdirProvider() { | ||
return [ | ||
'test_mkdir_temp', | ||
'test_mkdir_tempXXXXXX' | ||
]; | ||
} | ||
} | ||
|
||
TestSystemMkdirTest().run(); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's worth using the Result type here as mkdtemp can fail. In those situations it would be good to give some indication as to why it failed, we can do that by unwrapping a Result type