Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class Variable / Constant Annotations #627

Merged
merged 6 commits into from
Aug 16, 2023

Conversation

Jason2605
Copy link
Member

Well detailed description of the change :

This adds a new .variableAnnotations to classes that exposes any attached annotations to either class variables or class constants. Works exactly the same way as the other annotations where a dictionary is generated.

Resolves: #623

Type of change:

  • New feature

Housekeeping

  • Tests have been updated to reflect the changes done within this PR (if applicable).

  • Documentation has been updated to reflect the changes done within this PR (if applicable).

Preview (Screenshots) :

@Jason2605 Jason2605 self-assigned this Aug 14, 2023
@Jason2605
Copy link
Member Author

@briandowns This should be working now - not sure I'm happy with variableAnnotations when it is also used for constants (contradicting a bit), do you have an idea for a better name?

@briandowns
Copy link
Contributor

All of it looks great and I can't wait to finish the 2 modules I have in mind but as for the method name, I think I agree. How about fieldAnnotations?

@Jason2605
Copy link
Member Author

Thanks man 😄 Yeah I like it, will change it to that

docs/docs/classes.md Outdated Show resolved Hide resolved
Co-authored-by: Brian Downs <brian.downs@gmail.com>
@Jason2605 Jason2605 merged commit 32474c0 into develop Aug 16, 2023
8 checks passed
@Jason2605 Jason2605 deleted the feature/attributeAnnotations branch August 16, 2023 22:11
@Jason2605 Jason2605 mentioned this pull request Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] - Class Field Annotations
2 participants