Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

un-auto load C module #638

Merged
merged 2 commits into from
Aug 21, 2023
Merged

Conversation

briandowns
Copy link
Contributor

@briandowns briandowns commented Aug 21, 2023

Resolves: #637

What's Changed:

Updated the code to require the C module to be loaded like all other modules and not be autoloaded with the VM.

Type of Change:

  • Bug fix
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Housekeeping:

  • Tests have been updated to reflect the changes done within this PR (if applicable).
  • Documentation has been updated to reflect the changes done within this PR (if applicable).

Screenshots (If Applicable):

Signed-off-by: Brian Downs <brian.downs@gmail.com>
Signed-off-by: Brian Downs <brian.downs@gmail.com>
@briandowns briandowns marked this pull request as ready for review August 21, 2023 13:54
@briandowns briandowns changed the title [WIP] - un-auto load C module un-auto load C module Aug 21, 2023
@briandowns
Copy link
Contributor Author

@Jason2605 Here's the initial pass at the fix. Happy to add docs if necessary. Not really much there to test though but happy to add some.

@Jason2605
Copy link
Member

To be honest for the moment I'm happy with no tests / docs on this module, at the moment it's really just a bunch of constants since a lot got stripped out when we moved to Result types

@Jason2605
Copy link
Member

Thanks for this!

@Jason2605 Jason2605 merged commit e97b382 into dictu-lang:develop Aug 21, 2023
6 of 8 checks passed
@briandowns briandowns deleted the fix_c_global branch August 21, 2023 21:37
This was referenced Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - Unable to Create class, var, or const with the Name "C"
2 participants