Introduce header_id as parameter for headers
#78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
==========================================
+ Coverage 85.21% 85.77% +0.55%
==========================================
Files 12 12
Lines 460 478 +18
Branches 88 87 -1
==========================================
+ Hits 392 410 +18
Misses 47 47
Partials 21 21
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
didix21
reviewed
Dec 9, 2022
.github/workflows/main.yml
Outdated
| @@ -16,10 +16,10 @@ jobs: | |||
|
|
|||
| steps: | |||
| - uses: actions/checkout@v2 | |||
| - name: Set up Python 3.6 | |||
There was a problem hiding this comment.
Is a requirement to update python version for this P.R?
There was a problem hiding this comment.
No, it's not but the workflow to calculate the coverage doesn't work with version 3.6. I removed this commit
didix21
approved these changes
Dec 10, 2022
didix21
changed the title
header_id as parameter for headersheader_id as parameter for headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #77
This PR adds the option to create atx-headers with an ID for extended Markdown Syntax.