Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.6. Windows w/ Python 3.7 as optional. #38

Merged
merged 3 commits into from
Sep 19, 2022

Conversation

kdewald
Copy link
Collaborator

@kdewald kdewald commented Sep 16, 2022

I've encountered plenty of issues of matrix.experimental not being defined. This should solve it.

@kdewald kdewald changed the title Explicitly mark all builds as non-experimental. Remove Python 3.6. Windows w/ Python 3.7 as optional. Sep 19, 2022
@kdewald
Copy link
Collaborator Author

kdewald commented Sep 19, 2022

@diegoferigo I could not fully reproduce this problem on my machine, so I decided to go with your recommendation to mark the Python 3.7 Windows build as optional to have the CI pass.

I removed setuptools-scm from the examples (as that version is not being used) and left the setuptools version unrestricted, as such older versions should not longer be around and could be helpful to diagnose other problems.

I think the issue with Python 3.7 might be some tool being outdated and causing problems.

Copy link
Owner

@diegoferigo diegoferigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kdewald for your tests! I suspect the problem is specific to details of the Windows environment in CI, I would not waste more time trying to debug it. If any user will face problems in the future, we can use their system as reference to provide support.

example/pyproject.toml Show resolved Hide resolved
Co-authored-by: Diego Ferigo <dgferigo@gmail.com>
@kdewald kdewald merged commit f4a9553 into diegoferigo:master Sep 19, 2022
@kdewald kdewald deleted the bugfix/ci branch September 19, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants