Breaking API change to support base type comparison #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ected and and IEquatable<T> made explicit for classes.
Breaking API change to support base type comparison.
…ncremental interface.
Removes the need for Generator.Equals.Runtime
Net48 tests
…th Generator.Equals.
… the assembly caused unexpected issues.
|
@ssttgg hey mate, have you had a chance to look at this? 🌝 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking API change to support base type comparison. Equals made protected and IEquatable made explicit for classes.
Also, changes to the coding generation method, using a newer version of the code analyzers package. More tests other bits and bobs.