Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flex #1341

Merged
merged 1 commit into from
Jun 1, 2021
Merged

fix flex #1341

merged 1 commit into from
Jun 1, 2021

Conversation

jeetiss
Copy link
Collaborator

@jeetiss jeetiss commented May 31, 2021

fix #1332

changes:

  • tests
  • convert flex to string before split
  • use flex defaults instead of value as fallback

@staevs
Copy link

staevs commented May 31, 2021

suppose types (interface Style) should be updated as well in types/style.d.ts line 7 from flex?: number to flex?: string

@jeetiss
Copy link
Collaborator Author

jeetiss commented May 31, 2021

@staevs thanks for review, typed updated already
https://github.com/diegomura/react-pdf/blob/master/packages/types/style.d.ts#L7

@staevs
Copy link

staevs commented May 31, 2021

yep, now I see it in main repo, but were they published already as after installing version 2.0.2 (@react-pdf/types) I still have definition flex?: number?

@diegomura diegomura merged commit 4cc5453 into diegomura:master Jun 1, 2021
@diegomura
Copy link
Owner

Thanks!! Will deploy a new version later today

@leandrovegacr
Copy link

Just run into this issue today, I was so puzzled. Great to see you got it covered, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest update 2.0.13 produces a flexbox error when using "flex"
4 participants