Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use styles for forcing nodes height after split #1659

Merged
merged 4 commits into from
Jan 15, 2022
Merged

fix: use styles for forcing nodes height after split #1659

merged 4 commits into from
Jan 15, 2022

Conversation

jeetiss
Copy link
Collaborator

@jeetiss jeetiss commented Dec 22, 2021 •
edited

fix #1634

TODOs

  • remove logs
  • add test names
  • add changeset

@jeetiss jeetiss mentioned this pull request Jan 13, 2022
Merged
2 tasks
@jeetiss jeetiss self-assigned this Jan 13, 2022
diegomura
diegomura approved these changes Jan 14, 2022
View reviewed changes
Copy link
Owner

@diegomura diegomura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeetiss jeetiss merged commit 6f0e8d2 into master Jan 15, 2022
@jeetiss jeetiss deleted the fix-split-node branch January 15, 2022 10:42
@github-actions github-actions bot mentioned this pull request Jan 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diegomura diegomura diegomura approved these changes

Assignees

@jeetiss jeetiss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

View component does not fill the remaining space on the page after 2.0.21 update
2 participants
@jeetiss @diegomura