feat: add bidi support #2600
Merged
feat: add bidi support #2600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6f9290f The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Glad to finally see this get merged! |
|
Thanks a lot @diegomura and @ahmedwalid05, we were waiting for these PRs a long time now.
Once we'll start using it, we could give you guys feedback. |
mskec
pushed a commit
to mskec/react-pdf
that referenced
this pull request
Feb 26, 2024
Co-authored-by: Ahmed <ahmed@novalabs-qa.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1571
Fixes #1636
Fixes #933
Fixes #960
Fixes #1394
Fixes #747
Fixes #856
Mirror of #1485
Mirror of #1821
All props should go to @ahmed-novalabs really. He continued my work on this topic. His fork ended up having tons of conflicts, and tried to rebase but just messed it up, sorry. If someone knows how can I rebase someone else's PR branch I'd appreciate it. Every time I mess it up. I'll add him as co-author though so PR should not matter that much. In here I was able to bring changes one by one while I also tested them.
I tested it and just by seeing glyphs I see them being rendered correctly, but I can't really read any rtl language to catch small bugs that might have, so any help will be appreciated moving forward.