-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: jpeg precision metadata #2689
Conversation
🦋 Changeset detectedLatest commit: 510baf2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
Thanks! |
@diegomura I installed latest version of If they are deployed, just a note that the build output from this change doesn't align to the expected one, the line change I added isn't present basically. Sorry if its just because deployment is bundled with other changes, just saw a release yesterday so thought it might have been this. |
I am wondering the same thing as @joelybahh above. I've been trying to deploy an update on this all day. It looks like npm is not updated with these changes yet. Anything you can do here @diegomura ? |
@knuula I noticed some E2E tests failed on the merge of this, maybe the tests are checking against PDF output that is now technically different due to the |
See this PR: #2690 |
Fix #2625
Implementing the improved fix off of the back of oogas pull request, and information from this comment thread.
this.bits
being undefined, which was problematic in more strict PDF viewers such as Adobe, Mac Preview and Safari.I had the time and wanted to trial the open source flow anyway (Feel free to decline this if this is overstepping someone else's work I'm not trying to take credit or anything, I am simply looking to get this fix rolled out ASAP as we are using it in a company project).
Trying to be helpful in expediting is all.