fix(Text): dont add additional x value for lines #469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arahansen
commented
Jan 28, 2019
| @@ -28,4 +34,27 @@ describe('Text', () => { | |||
| expect(text.layoutEngine.layout.mock.calls).toHaveLength(1); | |||
| expect(text.layoutEngine.layout.mock.calls[0][0].string).toBe(''); | |||
| }); | |||
|
|
|||
| test('Should render the same rect x value for clones', async () => { | |||
There was a problem hiding this comment.
I dont love how this test is constructed. Let me know if you have a better means to test this!
There was a problem hiding this comment.
I think is fine! Maybe there's a simpler way, but this is not bad either. Thank you very much!
diegomura
approved these changes
Jan 29, 2019
| @@ -28,4 +34,27 @@ describe('Text', () => { | |||
| expect(text.layoutEngine.layout.mock.calls).toHaveLength(1); | |||
| expect(text.layoutEngine.layout.mock.calls[0][0].string).toBe(''); | |||
| }); | |||
|
|
|||
| test('Should render the same rect x value for clones', async () => { | |||
There was a problem hiding this comment.
I think is fine! Maybe there's a simpler way, but this is not bad either. Thank you very much!
|
would it be possible to get a release cut that includes this change? Would love to integrate this back into my project 🙂 |
|
Definitely! I will release a new fix today. Sorry about the delay |
|
No worries, I really appreciate your responsiveness and help getting started with the project! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Text nodes are cloned, the container is copied over, including x offsets for each line. For
fixedText elements, this means that the x value was being accumulated on top of the original rect offset which resulted in this shifting effect that gradually grows worse for each page thefixedelement shows up on.I don't have an exact repro jsx but it would look roughly like this:
Before fix:
After fix:
Fixes #361