Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add cargo audit dependency check #6116

Closed
wants to merge 1 commit into from
Closed

CI: add cargo audit dependency check #6116

wants to merge 1 commit into from

Conversation

boozook
Copy link

@boozook boozook commented Sep 21, 2020

Add cargo-audit auto-checks as gh-action.

Motivation

Automated checks vulnerable or stale dependencies is necessary at all by security and stability reasons.

Also the action produces neat report (example).

Have you read the Contributing Guidelines on pull requests?

Yup.

Test Plan

This is small extra part for CI.

@diem-cla-bot
Copy link

diem-cla-bot bot commented Sep 21, 2020

Need CLA signature Needs signature

Thank you for your submission. We require all contributors to
sign the CLA before we can accept your contribution.

Have you signed the CLA already, but your status is still pending? Recheck CLA

@rexhoffman
Copy link
Contributor

rexhoffman commented Sep 23, 2020

I'm reluctant to bring this in to the repo currently for a few reasons:

  1. we don't have agreement w/ gha's for compute capacity, and we are running a cargo audit nightly in circleci.
  2. Currently we fail the build if anything other than these 3 violations are found in circleci. https://github.com/libra/libra/blob/master/.circleci/config.yml#L564-L583
  3. I'm also a little reluctant to depend on gha that doesn't have the same config we use in circle, even if it doesn't currently break the build. Cargo versions/flags/etc.
  4. I'd need to look in to making sure versions are fully tied down, ideally to a git hash.

@metajack
Copy link
Contributor

Thanks for the contribution @fzzr-!

We do currently run cargo-audit as @rexhoffman has linked to, so there's no need to run another one in GHA. Should we decide to move our current job to GHA instead of CircleCI, we'll definitely keep actions-rs in mind.

@metajack metajack closed this Sep 23, 2020
@boozook boozook deleted the ci-add-cargo-audit branch September 23, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants