-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[json-rpc] add more tests #6280
Conversation
This PR may have modified JSON-RPC server code. Breaking changes policy:
Please ensure you have also done the following to update the docs:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
key: BytesView::from(event.key().as_bytes()), | ||
sequence_number: event.sequence_number(), | ||
transaction_version: txn_version, | ||
data: event_data.unwrap_or(EventDataView::Unknown {}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed
@bors-libra land |
Cluster Test Result
Repro cmd:
🎉 Land-blocking cluster test passed! 👌 |
70416eb
to
835774f
Compare
Still missing EventDataView::UpgradeEvent test, don't know how to generate it, will need talk to @runtian-zhou about it and add test later.
New event CreateAccountEvent is added, it is created recently (#6156).
Added new test to ensure there is no unknown events in integration tests at the end, to make test pass, created blank CreateAccountEvent for now (tried to decoded it, but got an error, so try to keep this diff simpler, will talk to @sblackshear to add created account address field if necessary)