Add target to attribute whitelist, closes #29 #30
Conversation
| @@ -162,7 +162,7 @@ private static void forceReleaseBuffer(ByteBuffer buffer) { | |||
|
|
|||
| public static String cleanPageText(final String dirtyPageText) { | |||
| final Whitelist whiteList = Whitelist.relaxed(); | |||
| whiteList.addAttributes(":all", "class", "id", "href", "docetref", "title", "package", "src"); | |||
| whiteList.addAttributes(":all", "class", "id", "href", "docetref", "title", "package", "src", "target"); | |||
There was a problem hiding this comment.
Agree with the change: can't think of any disadvantage but, maybe would be better to double-check that target attribute is adopted only on anchor referring to external target so as to avoid unexpected side-effects when working with internal links. This can be done by acting on validation checks on Docet maven Plugin for instance and, anyway, making sure, as well, that no target is present on an internal targeted anchor at runtime: the latter can be done by adding also runtime checks on DocetManager.
There was a problem hiding this comment.
@mcRoot see the discussion on #29
If the documentation writer uses the target attribute and Docet leaves it as it is the behaviour is unpredictable.
We could allow such attribute as you say at most in the case that the href is to an external target.
IMHO this is very important, Docet-ML is not a generic HT-ML !
No description provided.