Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve memory configuration #755 #757

Merged
merged 4 commits into from
Aug 30, 2021

Conversation

diegosalvi
Copy link
Contributor

This patch solves #755:

  • add a new set of configuration to be able to configure memory constraints based on a percentage of maximum memory and not an absolute number: server.memory.data.percentage, server.memory.index.percentage server.memory.pk.percentage. Actually data and pk are simply a configurable value for a previous fixed one. The index is new, see below

  • add a new set of configuration to enable indexes / data pages memory separation. Up untill now data and indexes was stored in the same memory space with the same constraint. Now you can configure server.memory.index.percentage (maximum memory percentage value, defaults to 0%) or server.memory.index.limit (byte fixed value, default to 0). If dedicated index memory resolves to a value more than 0 it will be used instead of data memory. By default index will continue to share data memory

  • Due to memory inspections I noted that memory occupancy is evaluated enough well, we don't need to keep up to 50% memory free by default for "every else". Increased data default space from 30% to 50%.

  • [ x ] I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

@diegosalvi
Copy link
Contributor Author

Some test failed, it seems only testing problems, checking them

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nicoloboschi nicoloboschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work!

@nicoloboschi nicoloboschi merged commit ae2f2ce into master Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants