-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all uses of unwrap
from our docs
#34
Comments
How do you figure that'd work for examples using |
I think that |
The example using |
I don't think we need to teach users how to handle error cases, but if we can avoid |
If this repo is going to be a popular place for people who newer to Rust (which I think it will be) it is important to show how to do it the right way. Or don't show it at all. Perhaps saving the Result as a variable and then a comment underneath about dealing with the result? |
Shouldn't this be closed because of the above PR? If not, I'm more than willing to finish what work wasn't covered by #45! |
I think that there are still a few places left but I can't confirm at the moment. Feel free to let me know if that's the case |
Ah, I see what you're talking about. Upon doing a global project search for Anyways, I'm recommending closing this issue and my Issue #34 PR if everything is as it should be. Sorry for the misunderstanding! |
Thanks! On Thu, May 12, 2016 at 7:31 AM Taylor Jones notifications@github.com
|
It's a terrible habit, and I agree that we shouldn't have it in our docs. I've gotten rid of a decent number recently, but I'd like to eliminate the rest in favor of
try!
(this will take some annoying boilerplate in our doctests, but it's probably worth it).The text was updated successfully, but these errors were encountered: