[Issue #34] - removing more instances of .unwrap() from documentation in favor of try!() #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in favor of try
hiimtaylorjones
changed the title
hiimtaylorjones
changed the title
| @@ -23,7 +23,7 @@ use types::VarChar; | |||
| /// # use diesel::insert; | |||
| /// # let connection = establish_connection(); | |||
| /// # insert(&NewUser { name: "Ha%%0r".into() }).into(users) | |||
| /// # .execute(&connection).unwrap(); | |||
| /// # .try!(execute(&connection)); | |||
There was a problem hiding this comment.
Sadly, macros (which try! is) can't be called like methods, so the entire expression needs to be wrapped. You can try...
try!(insert(..).into(..).execute(..));There was a problem hiding this comment.
😢 Well that's a bummer.
Thanks for the pointer! Pushing up the change in a few.
|
I don't think any of these cases really need to be changed. We can't use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #34, there were still a few instances of .unwrap() left in documentation. So, this (hopefully) covers some more ground towards eliminating these instances.
Please note that
try!()is a new Rust idiom to me personally, but I think I was able to get the hang of it pretty quickly. There's definitely a chance I messed something up though!