Support database schemas with spaces and dashes #2173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weiznich
requested changes
Sep 25, 2019
zoewithabang
force-pushed
the
schema-unmappable-chars
branch
from
1a87391
to
cd1ca8a
Compare
zoewithabang
force-pushed
the
schema-unmappable-chars
branch
from
cd1ca8a
to
9862026
Compare
|
Sorry for taking a while to get back to this, real life has been hitting me hard this month. 🙂 I had a look at doing the same for table schemas but was a bit unsure how to go about implementing it. If you think it's worth getting that in with this PR as well then I can have another go at it, any pointers would definitely help! 😄 |
zoewithabang
force-pushed
the
schema-unmappable-chars
branch
from
96d5a1f
to
eec65fa
Compare
weiznich
requested changes
Nov 22, 2019
- Using rust_name where appropriate - Added test to ensure schema names are still included where appropriate
zoewithabang
force-pushed
the
schema-unmappable-chars
branch
from
eec65fa
to
624718c
Compare
zoewithabang
force-pushed
the
schema-unmappable-chars
branch
from
915e53e
to
bff0cd8
Compare
abreis
reviewed
Mar 17, 2020
| @@ -14,7 +14,9 @@ static RESERVED_NAMES: &[&str] = &[ | |||
| "type", "typeof", "unsafe", "unsized", "use", "virtual", "where", "while", "yield", | |||
| ]; | |||
|
|
|||
| fn is_reserved(name: &str) -> bool { | |||
| static UNMAPPABLE_CHARS: &[char] = &['-', ' ']; | |||
There was a problem hiding this comment.
SQL table names can use other characters that would not translate well to a Rust identifier (e.g., a colon :).
Rust identifiers are restricted to [a-z A-Z 0-9 _], so I think that a more robust approach would be to map any character outside of this range to an underscore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2168
I had a few issues in setting up my environment this weekend to be able to properly test the functionality past the unit test so I took a few assumptions on where sql names would be used over rust variable names (e.g. in
joinable!andallow_tables_to_appear_in_same_query!).Let me know if they need to be changed or if there are any other changes needed to complete this PR, thanks.