Fix #3790 #3794
Merged
Fix #3790 #3794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue in `#[derive(Selectable)]` that caused generating invalid rust code for structs with lifetimes (and type parameters). It improves the derive to handle type parameters and lifetimes correctly. In addition it also improves the derive to generate an error if we find a reference, as plain references are not supported as load target by diesel.
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
weiznich
added a commit
to weiznich/diesel
that referenced
this pull request
Sep 22, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue in
#[derive(Selectable)]that caused generating invalid rust code for structs with lifetimes (and type parameters). It improves the derive to handle type parameters and lifetimes correctly. In addition it also improves the derive to generate an error if we find a reference, as plain references are not supported as load target by diesel.