Add support for timestamp with time zone #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review? @diesel-rs/contributors |
|
LGTM, though I'd probably add a few tests for edge cases like inserting a datetime in one time zone and trying to get it out in another. Is this a feature that is regularly used? Do you want to add some docs for that (even if you copying the ones from |
|
You mean documentation for the SQL type itself? Yeah I'll update that PR adding those docs after I merge this. |
This adds support for the `timestamp with time zone` type. This is part of the SQL standard, but not supported explicitly by SQLite as far as I can tell. As such I've made it a PG specific type for now. timestamp with time zone does not actually mean that a time zone is stored. It instead means that when dealing with strings, Postgres will no longer ignore the time zone portion. It will convert the time zone to UTC for storage. When transmitted as text, it will be converted to the database's local time zone. When transmitted as binary, it will be sent as UTC. As such, I've provided `ToSql` implementations for basically all flavors of `DateTime`, but I've only provided a `FromSql` implementation for `DateTime<UTC>` and `NaiveDateTime`. I have not provided any implementation for `std::time::SystemTime`, as it implies local time zone for the machine and we do not have the tools to handle the conversion in the standard library. Fixes #106. Fixes #295. Fixes #402.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for the
timestamp with time zonetype. This is partof the SQL standard, but not supported explicitly by SQLite as far as I
can tell. As such I've made it a PG specific type for now.
timestamp with time zone does not actually mean that a time zone is
stored. It instead means that when dealing with strings, Postgres will
no longer ignore the time zone portion. It will convert the time zone to
UTC for storage. When transmitted as text, it will be converted to the
database's local time zone. When transmitted as binary, it will be sent
as UTC.
As such, I've provided
ToSqlimplementations for basically all flavorsof
DateTime, but I've only provided aFromSqlimplementation forDateTime<UTC>andNaiveDateTime. I have not provided anyimplementation for
std::time::SystemTime, as it implies local timezone for the machine and we do not have the tools to handle the
conversion in the standard library.
Fixes #106.
Fixes #295.
Fixes #402.