Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch GitHub CI jobs from macos-11 to macos-13 #8328

Merged
merged 8 commits into from
Jun 17, 2024

Conversation

tautschnig
Copy link
Collaborator

macos-11 will no longer be available as a runner after 28 June 2024.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

Attention: Patch coverage is 34.32836% with 44 lines in your changes missing coverage. Please review.

Project coverage is 78.34%. Comparing base (2a5151c) to head (4eadc8a).

Files Patch % Lines
src/ansi-c/c_typecheck_expr.cpp 40.00% 12 Missing ⚠️
src/util/config.cpp 11.11% 8 Missing ⚠️
src/ansi-c/scanner.l 33.33% 6 Missing ⚠️
src/cpp/parse.cpp 25.00% 6 Missing ⚠️
src/ansi-c/c_expr.h 0.00% 4 Missing ⚠️
src/ansi-c/parser.y 0.00% 4 Missing ⚠️
src/ansi-c/c_expr.cpp 0.00% 2 Missing ⚠️
src/ansi-c/gcc_version.cpp 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8328      +/-   ##
===========================================
+ Coverage    78.32%   78.34%   +0.01%     
===========================================
  Files         1722     1722              
  Lines       188404   188394      -10     
  Branches     18454    18493      +39     
===========================================
+ Hits        147572   147600      +28     
+ Misses       40832    40794      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Although not officially documented it seems that GCC running on Apple
Silicon accepts __float128 as a keyword.

Fixes: diffblue#8305
Add a new parser configuration setting to correctly configure the
scanner.
This isn't as precise, but will avoid the cost of process invocation.
Such cost is considerable on Windows and appears to be around 100ms on
macOS.
@tautschnig tautschnig force-pushed the github-no-macos-11 branch 5 times, most recently from bc65e7c to cde491e Compare June 17, 2024 07:53
This test used to be THOROUGH but then seemed to be quick. Changes to
the sequence of equations, however, may adversely affect the runtime
with MiniSat.
This is supported by Clang and GCC (though in C++-mode only) and now
required for SIMD1 on macOS.
These are used in GCC/Clang built-ins.
Clang uses these builtins in SIMD operations.
macos-11 will no longer be available as a runner after 28 June 2024.
@tautschnig tautschnig merged commit bc46c88 into diffblue:develop Jun 17, 2024
39 of 40 checks passed
@tautschnig tautschnig deleted the github-no-macos-11 branch June 17, 2024 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants