random traces: set random initial state #517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
approved these changes
May 21, 2024
src/ebmc/random_traces.cpp
Outdated
| auto symbol_in_timeframe = instantiate(symbol, 0, 1, ns); | ||
| auto constraint = | ||
| equal_exprt(symbol_in_timeframe, random_value(symbol.type())); | ||
| result.push_back(constraint); |
There was a problem hiding this comment.
Nit pick: could use std::move(constraint)
| @@ -0,0 +1,10 @@ | |||
| CORE | |||
| initial_state1.v | |||
| --random-trace --trace-steps 1 --numbered-trace | |||
There was a problem hiding this comment.
I'd suggest to either explicitly add --random-seed 0 as command line option or add a comment at the bottom that 0 is the default random seed. Else it is not that obvious that random traces will always produce those "random" initial states.
Instead of relying on the user to initialize the state, we use random constraints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on the user to initialize the state, we use random constraints.