SuppressErrors #49
SuppressErrors #49
Conversation
Added suppressErrors argument to EclipseApp in order to prevent message dialogs on PDE errors.
|
Hi! Here is the fix for preventing the message boxes on errors while running EclipseApps (e.g. PDE). Sorry that it took a little longer than expected Regards, Ralf |
| .filter(Objects::nonNull) | ||
| .filter(arg -> !arg.startsWith("--launcher")) | ||
| .collect(toList()); | ||
| this.args = ImmutableList.copyOf(filteredArgs); | ||
| return this; |
There was a problem hiding this comment.
What is this filter for? If I pass --launcher.someFlag, it will be silently discarded, which will be quite hard to debug.
There was a problem hiding this comment.
I needed that for the P2BootstrapInstallationTest to pass, since unknown arguments will lead to an error (See log output at the end of this post). As i understood it, EquinoxLauncher is an alternate way to startup equinox, without having to use the native Eclipse launchers? The "--launcher" arguments are usually meant for the eclipse.exe or eclipsec.exe launchers and not passed further to Equinox. Please correct me, if my understanding is wrong. I would be glad for any better solution.
Installation failed.
!SESSION 2018-02-02 20:24:20.472 -----------------------------------------------
eclipse.buildId=unknown
java.version=1.8.0_112
java.vendor=Oracle Corporation
BootLoader constants: OS=macosx, ARCH=x86_64, WS=cocoa, NL=de_DE
Framework arguments: --launcher.suppressErrors -application org.eclipse.equinox.p2.director -repository http://download.eclipse.org/eclipse/updates/4.5/R-4.5.2-201602121500/ -installIU org.eclipse.core.runtime -profile profile -destination file:///var/folders/4d/z5fm5n5x5gsdzwswfrfd7b100000gn/T/junit191409443383839977/installed
Command-line arguments: --launcher.suppressErrors -application org.eclipse.equinox.p2.director -clean -consolelog -repository http://download.eclipse.org/eclipse/updates/4.5/R-4.5.2-201602121500/ -installIU org.eclipse.core.runtime -profile profile -destination file:///var/folders/4d/z5fm5n5x5gsdzwswfrfd7b100000gn/T/junit191409443383839977/installed
!ENTRY org.eclipse.equinox.p2.core 4 0 2018-02-02 20:24:20.474
!MESSAGE Unknown option --launcher.suppressErrors. Use -help for a list of known options.
There was a problem hiding this comment.
Ahhhh, I see. You are correct about EqunoxLauncher.
I think a safer bet here would be to filter --launcher.suppressErrors only. There are quite a few --launcher flags, and it may be that some of them are supported by EquinoxLauncher.
There was a problem hiding this comment.
Allright. I changed that
replaced the argument filter for EquinoxLauncher for more precise filtering
* Allow providing a pde bootstrap installation like p2bootstrap feature does with a pdebootstrapurl override This can be an advantage if you are behind restrictive proxies bc by default pde is downloaded from p2 repos * change whitespaces to tabs for spotless * add #49 to changes.md * mixed up pull requests
|
the workspace and log is cleared immediately after eclipse exits. with the error dialog i was able to read the log until a manual click. how do i preserve the log in case of error with suppressErrors activated? edit: this could be a possible solution #55, what do you think? |
|
Hi! Sorry for the late response. Is there already a solution for the cleared workspace? Otherwise I would fix this, as i have another workspace issue that i am going to fix: Since we are building more than one product, there might be parallel (multithreaded) executions of PDE which is currently not possible, since the PdeInstallation always uses the same workspace directory. My idea is to make this configurable. Any suggestions? Regards, Ralf |
|
with this feature #55 one can activate consoleLog and get all the errors during the gradle run. no need for log files or workspace anymore. for a different workspace dir you could extend |
|
A few other tips:
|
Added suppressErrors argument to EclipseApp in order to prevent message dialogs on PDE errors.