Trickybrain Creating the LineReader file

[Trickybrain]

Trickybrain Creating the LineReader file

[nedtwigg]

The pyright errors here are saving you from a real problem:

/home/runner/work/selfie-python-wip/selfie-python-wip/python/selfie-lib/selfie_lib/LineReader.py
/home/runner/work/selfie-python-wip/selfie-python-wip/python/selfie-lib/selfie_lib/LineReader.py:7:30 - error: Cannot assign member "unix_newlines" for type "LineTerminatorAware*"
Type "Literal[True]" cannot be assigned to type "() -> (() -> ...)" (reportAttributeAccessIssue)
/home/runner/work/selfie-python-wip/selfie-python-wip/python/selfie-lib/selfie_lib/LineReader.py:10:34 - error: Cannot assign member "unix_newlines" for type "LineTerminatorAware*"
Type "Literal[False]" cannot be assigned to type "() -> (() -> ...)" (reportAttributeAccessIssue)
/home/runner/work/selfie-python-wip/selfie-python-wip/python/selfie-lib/selfie_lib/LineReader.py:21:38 - error: Cannot assign member "unix_newlines" for type "LineTerminatorAware*"

Look at lines 7/10/21. Let me know if you'd like another hint.

[nedtwigg]

• make sure to add type hints, see Type hints & ChatGPT #16

[nedtwigg]

Getting closer! The errors that pyright is giving you in CI are all helpful.

You don't have to push to CI to find them, you can also run them locally with poetry run pyright.

[nedtwigg]

This looks excellent! Two things it needs to be finished

• small nit about public/private
• it is missing the def get_line_number(self) -> int: method mentioned earlier. The later steps will be very difficult to debug without it. We can count the lines ourselves, we don't need Python's library implementation to do it.

[nedtwigg]

Great work! Take a look at the small commit I pushed up above, private is two underscores not one.

• Now that Convert LineReader #5 is done, you can start PerCharacterEscaper, the next piece of Epic: .ss file read/write #7
• Create an issue for it
• link to the kotlin code that you're going to port, and any tests that are relevant to it
• then start writing python code